Merged
Conversation
WyriHaximus
requested changes
Feb 28, 2024
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
Looks good overall, but found some points worth addressing.
clue
reviewed
May 16, 2024
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for looking into this! Excellent work so far, only spotted some minor oversights below.
Also noticed that there are still a number of assertInstanceOf() calls with class name strings. I would suggest updating this to the class syntax (StringClassNameToClassConstantRector is your friend) while we're at it as suggested in reactphp/stream#175 (review).
SimonFrings
force-pushed
the
php7.1
branch
2 times, most recently
from
41f11e0 to
edfcecd
Compare
clue
approved these changes
May 18, 2024
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
WyriHaximus
approved these changes
May 19, 2024
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
Sweet, thanks for updating everything 👍
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 22, 2024
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs. Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch. Builds on top of reactphp#182, reactphp#222 and reactphp/promise#260
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 27, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 27, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 30, 2024
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs. Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch. Builds on top of reactphp#182, reactphp#222 and reactphp/promise#260
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 5, 2024
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs. Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch. Builds on top of reactphp#182, reactphp#222 and reactphp/promise#260
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 5, 2024
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs. Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch. Builds on top of reactphp#182, reactphp#222 and reactphp/promise#260
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 5, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 14, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 14, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the project to require PHP 7.1+ and drop legacy PHP < 7.1 and HHVM as discussed in #219. I'm marking this as a BC break for anybody still stuck on very old PHP versions, but there's little chance this will affect any current projects otherwise.
This PR aims to contain the minimal changeset to update the PHP version requirement only. Follow-up PRs will update our APIs to leverage newer language features.
FYI: I used reactphp/cache#58, reactphp/stream#175 and reactphp/event-loop#276 as inspiration.
Builds on top of #101, #170, #217, #220 and others